Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add params to connect method and update starknetkit modal to use… #134

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

bluecco
Copy link
Contributor

@bluecco bluecco commented Oct 2, 2024

Issue / feature description

Argent mobile in app browser always shows the connect modal on autoconnect
this is because the injected connector doesn't support the param silent_mode

Changes

  • updated connect method adding params as optional (to keep compatibility with starknet-react)
  • update connect function in main.ts when modalMode is neverAsk to use silent_mode: true

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.

Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.

@bluecco bluecco requested review from Inukares, Cussone and dhruvkelawala and removed request for dhruvkelawala October 2, 2024 09:44
@bluecco bluecco merged commit 28c82c0 into develop Oct 2, 2024
1 check passed
@bluecco bluecco deleted the fix/connect-injected-wallet branch October 2, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants